{"id":"GHSA-8mj7-wxmc-f424","aliases":["RUSTSEC-2022-0028"],"url":"https://o3.security/vulnerability/GHSA-8mj7-wxmc-f424","summary":"Use after free in Neon external buffers","details":"Neon provides functionality for creating JavaScript `ArrayBuffer` (and the `Buffer` subtype) instances backed by bytes allocated outside of V8/Node. The [`JsArrayBuffer::external`](https://docs.rs/neon/0.10.0/neon/types/struct.JsArrayBuffer.html#method.external) and [`JsBuffer::external`](https://docs.rs/neon/0.10.0/neon/types/struct.JsBuffer.html#method.external) did not require `T: 'static` prior to Neon `0.10.1`. This allowed creating an externally backed buffer from types that may be freed while they are still referenced by a JavaScript `ArrayBuffer`.\n\nThe following example demonstrates use after free. It compiles on versions `<0.10.1` and fails to compile afterward.\n\n```rust\npub fn soundness_hole(mut cx: FunctionContext) -> JsResult<JsArrayBuffer> {\n    let mut data = vec![0u8, 1, 2, 3];\n    \n    // Creating an external from `&mut [u8]` instead of `Vec<u8>` since there is a blanket impl\n    // of `AsMut<T> for &mut T`\n    let buf = JsArrayBuffer::external(&mut cx, data.as_mut_slice());\n\n    // `buf` is still holding a reference to `data`!\n    drop(data);\n\n    Ok(buf)\n}\n```\n","published":"2022-06-17T00:13:40Z","modified":"2023-11-08T04:17:25.410603Z","cvss":null,"epss":null,"cisaKev":null,"exploitsKnown":0,"affectedPackages":[{"ecosystem":"crates.io","name":"neon","fixedVersion":"0.10.1"}],"fix":null,"references":[{"type":"WEB","url":"https://github.com/neon-bindings/neon/issues/896"},{"type":"PACKAGE","url":"https://github.com/neon-bindings/neon"},{"type":"WEB","url":"https://rustsec.org/advisories/RUSTSEC-2022-0028.html"}],"provenance":{"sources":["OSV.dev","FIRST.org (EPSS)"],"lastVerified":"2023-11-08T04:17:25.410603Z"}}